git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: remove git_blame and rename git_blame2 to git_blame

From
Jakub Narebski <jnareb@gmail.com>
Date
Jun 6, 2008, 08:24 UTC
Message-ID
<m3wsl3x96p.fsf@localhost.localdomain>
In-Reply-To
<1212738812-31277-1-git-send-email-rgarciasuarez@gmail.com>
Rafael Garcia-Suarez <rgarciasuarez@gmail.com> writes:
> git_blame is dead code. It's possible to plug it in place of
> git_blame2, but I don't know whether anyone does still that,
> because git_blame2 can now be considered stable enough, I think.

First, the two competing subroutines, git_blame and git_blame2 are from the time when there were two competing 'blame' implementations, respectively git-annotate (in Perl) and git-blame. git-blame won, and nowadays git-annotate is builtin alias passing '-c' option (Use the same output mode as git-annotate) to git-blame.

git_blame and git_blame2 had not only different backend, but have different output as well. git_blame uses more columns, showing more info at first glance, while git_blame2 is simpler and less cluttered.

That said, removing git_blame is a good idea (there was even some patch on this mailing list doing that, but IIRC it was part of larger series, and somehow got dropped, at least for mainline gitweb). There is always history if we want to check how its output looked like.

Acked-by: Jakub Narebski <jnareb@gmail.com>
(FWIW, as I am not gitweb maintainer).
-- 
Jakub Narebski
Poland
ShadeHawk on #git
Previous: Rafael Garcia-Suarez
Message 2 of 2 in “gitweb: remove git_blame and rename git_blame2 to git_blame”
  1. gitweb: remove git_blame and rename git_blame2 to git_blameRafael Garcia-Suarez, Jun 6, 2008
  2. Jakub NarebskiJun 6, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.