Re: [PATCH] Fix capitalization of "renamelimit" in docs to agree with code
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Dec 19, 2011, 00:51 UTC
- Message-ID
- <m3ty4xfkpc.fsf@localhost.localdomain>
- In-Reply-To
- <4EEE86AC.2030802@pcharlan.com>
Pete Harlan <pgit@pcharlan.com> writes:
Show 5 quoted lines
> Signed-off-by: Pete Harlan <pgit@pcharlan.com> > --- > The documentation and bash-completion have always capitalized > "renamelimit" as "renameLimit". The code has always lowercased the > whole name. Repair the docs.
Key names are *case insensitive* so we can write it in docs in a way that is more clear, like 'renameLimit'.
Code compares with lowercased key name, so that is why it uses 'renamelimit'.
Show 9 quoted lines
> @@ -2122,7 +2122,7 @@ _git_config () > diff.ignoreSubmodules > diff.mnemonicprefix > diff.noprefix > - diff.renameLimit > + diff.renamelimit > diff.renames > diff.suppressBlankEmpty > diff.tool
Consitency - why you change diff.renameLimit but not diff.ignoreSubmodules?
-- Jakub Narebski