Re: [PATCH 1/1] Improve progress display in kB range.

From: James Cloos <cloos@jhcloos.com>
Date: Apr 21, 2009, 17:11 UTC
Message-ID: <m3skk2szgv.fsf@lugabout.jhcloos.org>
In-Reply-To: <alpine.LFD.2.00.0904210054190.6741@xanadu.home>

>>>>> "Nicolas" == Nicolas Pitre <nico@cam.org> writes:

Nicolas> On Sun, 19 Apr 2009, James Cloos wrote:

Show 5 quoted lines

>> When progress.c:throughput_string() is called, the variable total
>> invariably has its twelve least significant bits set.  Ie, it is
>> always the case that:
>> 
>> total & 0xFFF == 0xFFF

Nicolas> Could you please explain ow you come to that conclusion?

Empirical evidence.

Even since the current progress was added, it has always shown nn.99 KiB in that range. I added an extra snprintf(3) to show total in hex and it always ends in FFF.

I presume the progress function is getting called just before total hits a page boundry. In any case, the empirical evidence is clear. And only even seeing .99 is annoying. Hense the proposed patch.

-JimC

-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 1024D/ED7DAEA6