Re: What's cooking in git.git (May 2011, #02; Wed, 4)

From: Jakub Narebski <jnareb@gmail.com>
Date: May 5, 2011, 09:08 UTC
Message-ID: <m3sjstv7kz.fsf@localhost.localdomain>
In-Reply-To: <7vsjstc1pp.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 19 quoted lines

> --------------------------------------------------
> [Stalled]
> 
> * jn/gitweb-js (2011-04-28) 13 commits
>  - gitweb: Make JavaScript ability to adjust timezones configurable
>  - gitweb.js: Add UI for selecting common timezone to display dates
>  - gitweb: JavaScript ability to adjust time based on timezone
>  - gitweb: Unify the way long timestamp is displayed
>  - gitweb: Refactor generating of long dates into format_timestamp_html
>  - gitweb.js: Provide getElementsByClassName method (if it not exists)
>  - gitweb.js: Introduce code to handle cookies from JavaScript
>  - gitweb.js: Extract and improve datetime handling
>  - gitweb.js: Provide default values for padding in padLeftStr and padLeft
>  - gitweb.js: Update and improve comments in JavaScript files
>  - gitweb: Split JavaScript for maintability, combining on build
>  - Remove gitweb/gitweb.cgi and other legacy targets from main Makefile
>  - git-instaweb: Simplify build dependency on gitweb
> 
> Rerolled.  Waiting for comments.

Should I extract first two commits i.e.

   - Remove gitweb/gitweb.cgi and other legacy targets from main Makefile
   - git-instaweb: Simplify build dependency on gitweb

into a separate patch series? Even though their existence was triggered by further patches in series, or to be more exact

   - gitweb: Split JavaScript for maintability, combining on build

I think this cleanup is worthy on its own.

Show 9 quoted lines

> * jn/ctags (2011-04-29) 6 commits
>  - gitweb: Optional grouping of projects by category
>  - gitweb: Modularized git_get_project_description to be more generic
>  - gitweb: Split git_project_list_body in two functions
>  - gitweb: Mark matched 'ctag' / contents tag (?by_tag=foo)
>  - gitweb: Change the way "content tags" ('ctags') are handled
>  - gitweb: Restructure projects list generation
> 
> Waiting for comments.

Should I do and post benchmarks for

   - gitweb: Restructure projects list generation

change (when 'forks' feature is used)?

Note that "gitweb: Mark matched 'ctag' / contents tag (?by_tag=foo)" has ACK from Petr Baudis ('pasky'). I think http://repo.or.cz is main or even only user of content tags.

-- 
Jakub Narebski
Poland
ShadeHawk on #git