Re: [BUG?] t9500 --debug prints "sh: ++GIT_BINDIR++/git: not found"

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 27, 2010, 21:21 UTC
Message-ID: <m3ocafib6z.fsf@localhost.localdomain>
In-Reply-To: <20101027204954.GA31386@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 9 quoted lines

> Trying to run t9500-gitweb-standalone-no-errors.sh, I find:
> 
>  $ sh t9500-gitweb-standalone-no-errors.sh --debug
>  ok 1 - no commits: projects_list (implicit)
>  sh: ++GIT_BINDIR++/git: not found
>  ok 2 - no commits: projects_index
>  sh: ++GIT_BINDIR++/git: not found
>  ok 3 - no commits: .git summary (implicit)
>  [...]

> Ideas?  Is this expected behavior?

Fixed in 8ff76f4 (gitweb: Move call to evaluate_git_version after evaluate_gitweb_config, 2010-09-26):

    gitweb: Move call to evaluate_git_version after evaluate_gitweb_config
    
    This means that call to evaluate_git_version() is now inside
    run_request(), which means that is called for each request instead of
    once per starting gitweb; this matter currently only when using
    FastCGI interface (gitweb.fcgi).
    
    This change was done becayse evaluate_git_version() uses $GIT
    variable, which can be set / modified by gitweb config file... and it
    is modified this way by gitweb config file used in gitweb tests.
    Without this change there is spurious extra output from t9500 test
    when tests are run with '--debug' option.

which is part of

* jn/gitweb-test (2010-09-26) 4 commits
 - gitweb/Makefile: Include gitweb/config.mak
 - gitweb/Makefile: Add 'test' and 'test-installed' targets
 - t/gitweb-lib.sh: Add support for GITWEB_TEST_INSTALLED
 - gitweb: Move call to evaluate_git_version after evaluate_gitweb_config

-- 
Jakub Narebski
Poland
ShadeHawk on #git