Re: [PATCH 0/3 v3] minor gitweb modifications
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Dec 29, 2010, 22:41 UTC
- Message-ID
- <m3fwtgcido.fsf@localhost.localdomain>
- In-Reply-To
- <1293651215-4924-1-git-send-email-sylvain@abstraction.fr>
Sylvain Rabot <sylvain@abstraction.fr> writes:
Show 8 quoted lines
> here a three patch serie with minor updates for gitweb based on master. > > This serie has been improved regarding the comments of : > > - Jakub Narebski <jnareb@gmail.com> > - Jonathan Nieder <jrnieder@gmail.com> > > Regards.
A few comments, in this version about commit messages, not the code:
> Sylvain Rabot (3): > gitweb: add extensions to highlight feature
It is about adding support for supporting additional file extensions for syntax highlighting, not about extending the highlight feature or adding some plugin thingy to it, as one can think on first read.
> gitweb: remove test when closing file descriptor
It is about closing open pipe (file descriptor) without checking for error in the case where we don't care about errors in the caller; in short about not testing status of closing filehandle in git_highlight
> gitweb: add css class to remote url titles
It is about distinguishing visually type of link using styles; adding CSS class is just a way to do it.
This actually has few comments about code.
Show 8 quoted lines
> > gitweb/gitweb.perl | 18 +++++++++--------- > gitweb/static/gitweb.css | 5 +++++ > 2 files changed, 14 insertions(+), 9 deletions(-) > > -- > 1.7.3.4.523.g72f0d.dirty >
-- Jakub Narebski Poland ShadeHawk on #git