Re: [PATCHv2] compat: add a getpass() compatibility function

From: Jakub Narebski <jnareb@gmail.com>
Date: May 23, 2011, 17:59 UTC
Message-ID: <m3fwo5z4bi.fsf@localhost.localdomain>
In-Reply-To: <0301451F-9998-4208-8CE0-82B095DD5D32@gieschke.de>

Rafael Gieschke <rafael@gieschke.de> writes:

Show 11 quoted lines

> If NO_GETPASS is set, getpass is provided in compat/getpass.c from
> http://git.uclibc.org/uClibc/plain/libc/unistd/getpass.c
> (getpass() was renamed to gitgetpass()).
> 
> Signed-off-by: Rafael Gieschke <rafael@gieschke.de>
> ---
>  Makefile          |    6 +++
>  compat/getpass.c  |   98 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  git-compat-util.h |    5 +++
>  3 files changed, 109 insertions(+), 0 deletions(-)
>  create mode 100644 compat/getpass.c

Thanks. What is missing is optional automatic detection of this case, which means changes to configure.ac and config.mak.in; see e.g. how it is done for NO_STRLCPY.

-- 
Jakub Narebski
Poland
ShadeHawk on #git