Re: [PATCH] Documentation/config.txt: Order variables alphabetically
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Dec 1, 2010, 13:58 UTC
- Message-ID
- <m3eia14mu7.fsf@localhost.localdomain>
- In-Reply-To
- <1291209174-9239-1-git-send-email-jari.aalto@cante.net>
jari.aalto@cante.net writes:
Show 7 quoted lines
> From: Jari Aalto <jari.aalto@cante.net> > > > Signed-off-by: Jari Aalto <jari.aalto@cante.net> > --- > Documentation/config.txt | 1698 +++++++++++++++++++++++----------------------- > 1 files changed, 852 insertions(+), 846 deletions(-)
Why? What such large change is for?
Note that currently config variables are grouped by functionality: for example core.eol and core.safecrlf, or core.compression and core.loosecompression are close to each other.
I like the fact that we have first advice.*, then core.*, then mostly alphabetically sorted rest of configuration variables.
Show 10 quoted lines
> diff --git a/Documentation/config.txt b/Documentation/config.txt > index 6a6c0b5..6e92623 100644 > --- a/Documentation/config.txt > +++ b/Documentation/config.txt > @@ -142,313 +142,251 @@ advice.*:: > detachedHead:: > Advice shown when you used linkgit::git-checkout[1] to > move to the detach HEAD state, to instruct how to create > - a local branch after the fact. Default: true. > + a local branch after the fact. Default: true.
This change has nothing to do with ordering variables alphabetically, therefore IMHO it belongs in separate patch.
[...]
-- Jakub Narebski Poland ShadeHawk on #git