git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH] format-patch: thread as reply to cover letter even with in-reply-to

From
Jakub Narebski <jnareb@gmail.com>
Date
Feb 16, 2009, 20:52 UTC
Message-ID
<m3bpt2t8a6.fsf@localhost.localdomain>
In-Reply-To
<200902162134.28850.trast@student.ethz.ch>
Thomas Rast <trast@student.ethz.ch> writes:
> Jay Soffian wrote:
Show 7 quoted lines
> > I think this change may be okay, but I think to go with it the
> > cover-letter and all the patches should have a "References:" header
> > with the message-id given by --in-reply-to.
> 
> That's a completely separate issue.  I'm only proposing to change
> what is formatted as a reply to what, the In-Reply-To and References
> formatting is handled by the existing code.
Perhaps a follow-up patch then?
Show 22 quoted lines
>  That being said...
> 
> > RFC 2822 says:
> > 
> >    The "In-Reply-To:" and "References:" fields are used when creating a
> >    reply to a message.  They hold the message identifier of the original
> >    message and the message identifiers of other messages (for example,
> >    in the case of a reply to a message which was itself a reply).  The
> >    "In-Reply-To:" field may be used to identify the message (or
> >    messages) to which the new message is a reply, while the
> >    "References:" field may be used to identify a "thread" of
> >    conversation.
> 
> The References formatting can't satisfy the following requirement, two
> paragraphs further down in the RFC,
> 
>    The "References:" field will contain the contents of the parent's
>    "References:" field (if any) followed by the contents of the parent's
>    "Message-ID:" field (if any).
> 
> because it doesn't have access to the mail being replied to.  It
> merely sets References to the same as In-Reply-To.

I think "References:" field can be shortened, and although IIRC it is recommended to leave first ancestor, two separators, and three last ancestors in shortened "References:" header, it would be better if patches had both '--in-reply-to' message id AND cover letter id in "References:" header. That would make for safer threading...

-- 
Jakub Narebski
Poland
ShadeHawk on #git
Previous: Thomas RastNext: Thomas Rast
Message 9 of 26 in “bash completion: offer more options for gitk”
  1. bash completion: offer more options for gitkThomas Rast, Feb 14, 2009
  2. Junio C HamanoFeb 15, 2009
  3. Santi BéjarFeb 15, 2009
  4. 0/2 bash completion: more options for gitk/log/shortlogThomas Rast, Feb 16, 2009
  5. Thomas RastFeb 16, 2009
  6. format-patch: thread as reply to cover letter even with in-reply-toThomas Rast, Feb 16, 2009
  7. Jay SoffianFeb 16, 2009
  8. Thomas RastFeb 16, 2009
  9. Jakub NarebskiFeb 16, 2009
  10. Thomas RastFeb 16, 2009
  11. 0/4 format-patch --cover-letter --in-reply-toThomas Rast, Feb 19, 2009
  12. 1/4 format-patch: threading test reactivationThomas Rast, Feb 19, 2009
  13. 2/4 format-patch: track several referencesThomas Rast, Feb 19, 2009
  14. Daniel BarkalowFeb 19, 2009
  15. 0/4 format-patch --cover-letter --in-reply-toThomas Rast, Feb 20, 2009
  16. 1/4 format-patch: threading test reactivationThomas Rast, Feb 20, 2009
  17. 2/4 format-patch: track several referencesThomas Rast, Feb 20, 2009
  18. 3/4 format-patch: thread as reply to cover letter even with in-reply-toThomas Rast, Feb 20, 2009
  19. 4/4 format-patch: support deep threadingThomas Rast, Feb 20, 2009
  20. Junio C HamanoFeb 22, 2009
  21. 3/4 format-patch: thread as reply to cover letter even with in-reply-toThomas Rast, Feb 19, 2009
  22. 4/4 format-patch: support deep threadingThomas Rast, Feb 19, 2009
  23. 1/2 bash completion: refactor common log, shortlog and gitk optionsThomas Rast, Feb 16, 2009
  24. 2/2 bash completion: only show 'log --merge' if mergingThomas Rast, Feb 16, 2009
  25. Shawn O. PearceFeb 18, 2009
  26. Junio C HamanoFeb 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.