Re: [PATCH RFC] gettext: Support building on non-GNU with -lintl

From: Jakub Narebski <jnareb@gmail.com>
Date: Jun 5, 2010, 11:42 UTC
Message-ID: <m3aar9r9ek.fsf@localhost.localdomain>
In-Reply-To: <1275669370-6004-1-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 9 quoted lines

> Change the build process on non-GNU systems to use -lintl if
> NO_GETTEXT hasn't been set.
> 
> Systems that use the GNU C Library don't need this, but on others the
> GNU libintl library is an externally install package, so we need to
> explicitly link to it.
> 
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---

[...]

Show 16 quoted lines

> diff --git a/Makefile b/Makefile
> index 5169aec..1dfcd65 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -28,6 +28,15 @@ all::
>  # Define NO_EXPAT if you do not have expat installed.  git-http-push is
>  # not built, and you cannot push using http:// and https:// transports.
>  #
> +# Define NO_GETTEXT if you don't have libintl installed, or don't want
> +# to build Git with localization support.
> +#
> +# Define NEEDS_LIBINTL if you haven't defined NO_GETTEXT=YesPlease,
> +# but your system needs to be explicitly linked to -lintl. This is
> +# defined automatically if we're building gettext support on systems
> +# where we expect not to use glibc (which has libintl included in
> +# libc).

Could you add test for NEEDS_LIBINTL to configure.ac? Thanks in advance.

-- 
Jakub Narebski
Poland
ShadeHawk on #git