Re: What's cooking in git.git (Feb 2012, #08; Wed, 22)

From: Jakub Narebski <jnareb@gmail.com>
Date: Feb 23, 2012, 11:29 UTC
Message-ID: <m38vjteqkj.fsf@localhost.localdomain>
In-Reply-To: <7vfwe26zwn.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> * jn/gitweb-hilite-regions (2012-02-19) 5 commits
>  - gitweb: Use esc_html_match_hl() in 'grep' search

This one is about starting unification of match highlighting in gitweb, using esc_html_match_hl() which can show multiple matches in line as opposed to existing hand-crafted and duplicated solutions.

>  - gitweb: Highlight matched part of shortened project description
>  - gitweb: Highlight matched part of project description when searching projects
>  - gitweb: Highlight matched part of project name when searching projects
>  - gitweb: Introduce esc_html_hl_regions

This is about adding match highlighting to project search. Other kinds of search in gitweb ('commit', 'grep' - both per-repository searches) already use match highlighting.

>  (this branch uses jn/gitweb-search-optim.)

Theoretically those topics should be independent, but I think there can be tetual conflict. Better to build one on top of the other.

Nb. should I send those series independently?

> Not reviewed and do not know what this is about yet ;-).

I hope that above description helps.

Show 8 quoted lines

> * jn/gitweb-search-optim (2012-02-19) 3 commits
>  - gitweb: Faster project search
>  - gitweb: Option for filling only specified info in fill_project_list_info
>  - gitweb: Refactor checking if part of project info need filling
>  (this branch is used by jn/gitweb-hilite-regions.)
> 
> The API introduced in the second step still has yucky design, but at least
> it is more clear than the previous rounds what this is trying to do.

Thanks for the comments.  I'll try to send re-roll soon.

-- 
Jakub Narebski