Re: [PATCH] send-mail: Add option to sleep between sending each email.

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 3, 2011, 20:17 UTC
Message-ID: <m37h5jt19v.fsf@localhost.localdomain>
In-Reply-To: <4E68CC08.4040201@unixsol.org>

Georgi Chorbadzhiyski <gf@unixsol.org> writes:

> Around 09/08/2011 04:58 PM, Georgi Chorbadzhiyski scribbled:

[...]

Show 22 quoted lines

> > In order for this to work, confirmation should be split from send_message()
> > and from a quick look this not seem very easy. Might be easier to just
> > disable the sleep if user was asked for confirmation. It'll be good to
> > not sleep after last email, but main "foreach my $t (@files) {" loop should
> > pass some hint to send_message().
> 
> The attached patch (apply on on top of the original) should implement the
> idea.
> 
> -- 
> Georgi Chorbadzhiyski
> http://georgi.unixsol.org/
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 7239fd4..d4559c9 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1149,7 +1149,7 @@ X-Mailer: git-send-email $gitversion
>  		}
>  	}
>  
> -	if (!$dry_run && $sleep) {
> +	if (!$dry_run && $sleep && $message_num < scalar $#files && $confirm eq 'never') {

                                                  ^^^^^^^^^^^^^^

>  		print "Sleeping: $sleep second(s).\n" if (!$quiet);
>  		sleep($sleep);
>  	};

Errr... what? If we have @files array, then '$#files' is index of last element in array, which is scalar anyway, and 'scalar $#files' is a no-op.

You can get number of elements in array with 'scalar @files', though _implicit_ scalar context would also work, like e.g. right hand side of '<' operator.

-- 
Jakub Narębski