Re: [PATCH 2/2] add test-dump-cache-tree in Makefile

From: Jakub Narebski <jnareb@gmail.com>
Date: Feb 4, 2009, 09:31 UTC
Message-ID: <m34ozawnte.fsf@localhost.localdomain>
In-Reply-To: <1233781241-721-2-git-send-email-guanqun.lu@gmail.com>

Guanqun Lu <guanqun.lu@gmail.com> writes:

Show 5 quoted lines

>  dump-cache-tree.c      |   64 ------------------------------------------------
>  test-dump-cache-tree.c |   64 ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 65 insertions(+), 64 deletions(-)
>  delete mode 100644 dump-cache-tree.c
>  create mode 100644 test-dump-cache-tree.c

> diff --git a/dump-cache-tree.c b/dump-cache-tree.c
> deleted file mode 100644
> index 1f73f1e..0000000

> diff --git a/test-dump-cache-tree.c b/test-dump-cache-tree.c
> new file mode 100644
> index 0000000..1f73f1e

Minor nit: it would be better to use git-format-patch with '-M' option (detect renames) here. It would result in shorter and more readable patch:

 dump-cache-tree.c => test-dump-cache-tree.c |  0
 3 files changed, 1 insertions(+), 0 deletions(-)
 rename dump-cache-tree.c => test-dump-cache-tree.c (100%)

diff --git a/dump-cache-tree.c b/test-dump-cache-tree.c
similarity index 100%
rename from dump-cache-tree.c
rename to test-dump-cache-tree.c

Or something like that...

-- 
Jakub Narebski
Poland
ShadeHawk on #git