Re: [PATCH v2] post-receive-email: explicitly set Content-Type header

From: Jakub Narebski <jnareb@gmail.com>
Date: Sep 20, 2011, 12:23 UTC
Message-ID: <m34o07s8sx.fsf@localhost.localdomain>
In-Reply-To: <20110920104256.GA11656@zapped.homeip.net>

Shumkin Alexey <zapped@mail.ru> writes:

> [ resent to mailing list ]
> On Tue, Sep 20, 2011 at 11:32:54AM +0200, Johannes Sixt wrote:
> > Am 9/20/2011 10:07, schrieb Alexey Shumkin:

[...]

Show 18 quoted lines

> > > +# hooks.emailcharset
> > > +#   The charset used in Content-Type header. UTF-8, if not
> > > specified.
> > 
> > How can you be sure that the output produced by git log etc. that are
> > used in the script are in the encoding specified by this variable?
> > IOW, wouldn't log.outputencoding be the better choice to use in the
> > Content-Type header?
>
> Yes, you're right, we cannot be sure in UTF-8 encoding of output
> and using i18n.logoutputencoding would be a better choice
> instead of new config variable.
> 
> But at the present
> 1. post-send-mail uses description file of a repo
> 2. gitweb also uses this file and AFAIK it assumes one to be in UTF-8
>   (I do not know whether it can be changed there but I tested gitweb once long
>     time ago)

I have thought that gitweb uses '--encoding=utf8' explicitly, but as I have checked it uses this only for git-format-patch invocation in 'patch' / 'patches' views. Should be fixed.

-- 
Jakub Narębski