Re: Change in git-svn dcommit semantics?

From: Seth Falcon <sethfalcon@gmail.com>
Date: Dec 20, 2006, 03:05 UTC
Message-ID: <m2zm9j6zdm.fsf@ziti.local>
In-Reply-To: <20061219220900.GA3148@localdomain>

Eric Wong <normalperson@yhbt.net> writes:

> Huh?  safe_qx should've croaked or died, causing git-svn to exit before
> it could do any damage (via git-reset or git-rebase).  dcommit is not
> called inside any eval blocks, either...

*shrug* weird. Looking at the code, I don't see how I could have seen what I think I did. Reproducing the error in a sandbox doesn't show the git-reset behavior. So unless I can reproduce it, I must have done something else funny. Sorry for the noise.

Show 5 quoted lines

> Before, the 'remotes/git-svn..HEAD' argument meant absolutely nothing to
> dcommit (it silently ignored it).  Nowadays, you only need 'HEAD~2', the
> 'remotes/git-svn..' is already implied.
>
> 	git-svn dcommit HEAD~2

That's convenient in that it requires less typing. I will try to retrain my fingers. I'm in the habit of reviewing the commits not in svn with:

  git log remotes/git-svn..HEAD

And then editing the command like to be 'svn dcommit' instead of log.

Cheers,

+ seth