Re: gitk broken or user error?

From: Seth Falcon <sethfalcon@gmail.com>
Date: Nov 13, 2006, 22:38 UTC
Message-ID: <m2y7qfezum.fsf@ziti.local>
In-Reply-To: <m27ixzgex4.fsf@ziti.local>

Seth Falcon <sethfalcon@gmail.com> writes:

> I tried this patch:

And then I used grep :-)

This patch seems to get the view menu items working. The only strange thing I see now is that if I create a new view and then try to delete it, it stays around in the menu.

+ seth

diff --git a/gitk b/gitk
index ab383b3..d9df0a3 100755
--- a/gitk
+++ b/gitk
@@ -1632,8 +1632,8 @@ proc showview {n} {
 
     set curview $n
     set selectedview $n
-    .bar.view entryconf 2 -state [expr {$n == 0? "disabled": "normal"}]
-    .bar.view entryconf 3 -state [expr {$n == 0? "disabled": "normal"}]
+    .bar.view entryconf "Edit*" -state [expr {$n == 0? "disabled": "normal"}]
+    .bar.view entryconf "Delete*" -state [expr {$n == 0? "disabled": "normal"}]
 
     if {![info exists viewdata($n)]} {
        set pending_select $selid
@@ -6305,8 +6305,8 @@ if {$cmdline_files ne {} || $revtreeargs
     set viewargs(1) $revtreeargs
     set viewperm(1) 0
     addviewmenu 1
-    .bar.view entryconf 2 -state normal
-    .bar.view entryconf 3 -state normal
+    .bar.view entryconf "Edit*" -state normal
+    .bar.view entryconf "Delete*" -state normal
 }