Re: [PATCH 3/3] grep: get rid of useless x < 0 comparison on an enum member
- From
Andreas Schwab <schwab@linux-m68k.org>
- Date
- Nov 6, 2011, 15:03 UTC
- Message-ID
- <m2pqh5nvic.fsf@igel.home>
- In-Reply-To
- <1320581184-4557-4-git-send-email-avarab@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 13 quoted lines
> Remove an "p->field < 0" comparison in grep.c that'll always be
> false. In this case "p" is a "grep_pat" where "field" is defined as:
>
> enum grep_header_field field;
>
> And grep_header_field is in turn defined as:
>
> enum grep_header_field {
> GREP_HEADER_AUTHOR = 0,
> GREP_HEADER_COMMITTER
> };
>
> Meaning that this comparison will always be false.The underlying integer type is implementation-defined, and can be any signed or unsigned integer type that can represent all enumerations.
Andreas.
-- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."