Re: [bug report] git-am applying maildir patches in reverse

From: Andreas Schwab <schwab@linux-m68k.org>
Date: Mar 2, 2013, 08:44 UTC
Message-ID: <m28v66198o.fsf@igel.home>
In-Reply-To: <20130302004120.GB14936@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 12 quoted lines

>  static int maildir_filename_cmp(const char *a, const char *b)
>  {
> -	while (1) {
> +	while (*a && *b) {
>  		if (isdigit(*a) && isdigit(*b)) {
>  			long int na, nb;
>  			na = strtol(a, (char **)&a, 10);
> @@ -148,6 +148,7 @@ static int maildir_filename_cmp(const char *a, const char *b)
>  			b++;
>  		}
>  	}
> +	return *a - *b;

You should always cast to unsigned char when determining the order of characters, to be consistent with strcmp/memcmp.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."