git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fix git-format-patch -s to include a Signed-off-by: line...

From
Eric W. Biederman <ebiederm@xmission.com>
Date
Jan 25, 2006, 20:03 UTC
Message-ID
<m1r76why76.fsf@ebiederm.dsl.xmission.com>
In-Reply-To
<7voe212h53.fsf@assigned-by-dhcp.cox.net>

In the last round of bug fixes the signed-off-by line was still be generated but it was not including a signed-off-by line :(

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
 git-format-patch.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
78308e7078be1beb979def50579722910f2ff54f
diff --git a/git-format-patch.sh b/git-format-patch.sh
index 7e67c4e..5fb8ce1 100755
--- a/git-format-patch.sh
+++ b/git-format-patch.sh
@@ -178,7 +178,7 @@ my ($signoff_pattern, $done_header, $don
     $last_was_signoff);
 
 if ($signoff) {
-	$signoff = `git-var GIT_COMMITTER_IDENT`;
+	$signoff = "Signed-off-by: " . `git-var GIT_COMMITTER_IDENT`;
 	$signoff =~ s/>.*/>/;
 	$signoff_pattern = quotemeta($signoff);
 }
-- 
1.1.4.g7830
Previous: Junio C Hamano
Message 2 of 2 in “diff-tree --cc: denser combined diff output for a merge commit.”
  1. 2/2 diff-tree --cc: denser combined diff output for a merge commit.Junio C Hamano, Jan 25, 2006
  2. Fix git-format-patch -s to include a Signed-off-by: line...Eric W. Biederman, Jan 25, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.