Re: [PATCH] Check and document the options to prevent mistakes.

From: Eric W. Biederman <ebiederm@xmission.com>
Date: Jun 22, 2006, 03:05 UTC
Message-ID: <m1irmt6gax.fsf@ebiederm.dsl.xmission.com>
In-Reply-To: <7vy7vqxmb7.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

Show 12 quoted lines

> ebiederm@xmission.com (Eric W. Biederman) writes:
>
>> +# Verify the user input
>> +
>> +foreach my $entry (@to) {
>> +	die "Comma in --to entry: $entry'\n" unless $entry !~ m/,/;
>> +}
>> +
>
> Perhaps, avoiding double negation would be easier on the eyes.
>
>         die ... if $entry =~ /,/

Sure double negation does get confusing. I think I forgot about that last if form. My perl is rusty from disuse.

> Does it grok '"Biederman, Eric W." <eb@xm.com>' some people seem
> to do properly, or do we care (I personally don't)?

Nope. If figure that is lesser of two evils. If I could properly grok that I would make it do things properly and parse a --cc option for multiple email addresses.

I think you can still specify those interesting forms in an alias file, like .mailrc.

The important thing is not to do a mailing and the discover your recipients didn't get the email.

Eric