git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[BUG] 'pread' : macro redefinition

From
Marat Radchenko <marat@slonopotamus.org>
Date
Mar 30, 2014, 13:44 UTC
Message-ID
<loom.20140330T154129-838@post.gmane.org>
In-Reply-To
<20140319213556.2FC3D4062B@wince.sfo.corp.google.com>
Stefan Zager <szager <at> chromium.org> writes:
Show 8 quoted lines
> 
> This adds a Windows implementation of pread.
> diff --git a/compat/mingw.h b/compat/mingw.h
> index 08b83fe..377ba50 100644
> --- a/compat/mingw.h
> +++ b/compat/mingw.h
> +ssize_t mingw_pread(int fd, void *buf, size_t count, off64_t offset);
> +#define pread mingw_pread
This result in tons of following warnings in MSVC=1 build:

git-compat-util.h(401) : warning C4005: 'pread' : macro redefinition mingw.h(181) : see previous definition of 'pread'

Previous: Karsten Blees
Message 5 of 5 in “Enable index-pack threading in msysgit.”
  1. Enable index-pack threading in msysgit.Stefan Zager, Mar 19, 2014
  2. Junio C HamanoMar 19, 2014
  3. Duy NguyenMar 20, 2014
  4. Karsten BleesMar 21, 2014
  5. [BUG] 'pread' : macro redefinitionMarat Radchenko, Mar 30, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.