git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] simplifying branch.c:install_branch_config() if()

From
NANemina Amarasinghe <neminaa@gmail.com>
Date
Mar 14, 2014, 04:22 UTC
Message-ID
<loom.20140314T051213-863@post.gmane.org>
In-Reply-To
<20140314021052.GH15625@google.com>
 Is this safe?  Today branch.c::create_branch 
checks that the argument
> to e.g. --set-upstream-to is either in 
refs/heads/* or the image of
> some remote, but what is making sure that remains 
true tomorrow?
> 
> So if changing this, I would be happier if the 
"if" condition were
> still (!remote_is_branch && origin) so the 
impossible case could emit
Show 5 quoted lines
> a BUG.
> 
> Hope that helps,
> Jonathan
>

Thanks for the coments Jonathan, Yes you are correct... I was just thought about how to simplify this chain of if() statement. Not the big picture. Now I understand when I change or implenet something I have to think not only about the current matter but abot the future also.

Nemina
Previous: Jonathan Nieder
Message 3 of 3 in “simplifying branch.c:install_branch_config() if()”
  1. simplifying branch.c:install_branch_config() if()Nemina Amarasinghe, Mar 14, 2014
  2. Jonathan NiederMar 14, 2014
  3. Nemina AmarasingheMar 14, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.