Re: [PATCH v7 00/11] Add interpret-trailers builtin

From: Øystein Walle <oystwa@gmail.com>
Date: Mar 8, 2014, 11:54 UTC
Message-ID: <loom.20140308T124447-78@post.gmane.org>
In-Reply-To: <xmqq8uslu1bi.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster <at> pobox.com> writes:

Show 16 quoted lines

> 
> 	...
> 
> is easier to read and maintain if written like so (with using HT
> properly---our MUAs may damage it and turn the indentation into
> spaces):
> 
> 	... &&
> 	sed -e "s/ Z$/ /" >>expect <<-\EOF &&
>         Fixes: Z
>         Acked-by= Z
>         Reviewed-by: Z
>         Signed-off-by: Z
> 	EOF
> 	...
>

How about:

   printf '%s: \n' Fixes Acked-by Reviewed-by Signed-off-by >> expect

This solution scores high marks in both readability and maintainability in my mind.