Re: [PATCH v4] commit.c: use skip_prefix() instead of starts_with()

From: Tanay Abhra <tanayabh@gmail.com>
Date: Mar 4, 2014, 22:32 UTC
Message-ID: <loom.20140304T233205-398@post.gmane.org>
In-Reply-To: <xmqqvbvtiph8.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster <at> pobox.com> writes:

Show 15 quoted lines

> 
> Junio C Hamano <gitster <at> pobox.com> writes:
> 
> >> +		found = skip_prefix(buf, sigcheck_gpg_status[i].check + 1);
> >> +		if(!found) {
> 
> Missing SP between the control keyword and parenthesized expression
> the keyword uses.
> 
> I've fixed this (and the broken indentation) locally and queued the
> result to 'pu', so no need to resend to correct this one.
> 
> Thanks.
> 
>

Sorry about the indentation, it was due to not setting the tab to eight spaces. I found your mail late, so I had already sent a revised patch [1]. Please ignore that mail.

Also , what should be my next step ,should I present a rough draft of a proposal , or tackle other bugs on the mailing list?

Thanks for the suggestions and advice,

Regards, Tanay Abhra.

[1] http://article.gmane.org/gmane.comp.version-control.git/243395