git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 09/10] builtin/replace: unset read_replace_refs

From
Jakub Narebski <jnareb@gmail.com>
Date
Dec 7, 2013, 19:02 UTC
Message-ID
<loom.20131207T200130-598@post.gmane.org>
In-Reply-To
<20131207162106.21478.98950.chriscool@tuxfamily.org>
Christian Couder <chriscool <at> tuxfamily.org> writes:
Show 9 quoted lines
> 
> When checking to see if some objects are of the same type
> and when displaying the type of objects, git replace uses
> the sha1_object_info() function.
> 
> Unfortunately this function by default respects replace
> refs, so instead of the type of a replaced object, it
> gives the type of the replacement object which might
> be different.

Wasn't replace mechanism tightened, so that replacing object must be the same type as replaced object?

Is there a situation where you might want replace object with different type of object?

-- 
Jakub Narębski
Previous: Christian CouderNext: Christian Couder
Message 13 of 15 in “teach replace objects to sha1_object_info_extended()”
  1. 00/10 teach replace objects to sha1_object_info_extended()Christian Couder, Dec 7, 2013
  2. 01/10 Rename READ_SHA1_FILE_REPLACE flag to LOOKUP_REPLACE_OBJECTChristian Couder, Dec 7, 2013
  3. 02/10 replace_object: don't check read_replace_refs twiceChristian Couder, Dec 7, 2013
  4. 03/10 Introduce lookup_replace_object_extended() to pass flagsChristian Couder, Dec 7, 2013
  5. 04/10 Add an "unsigned flags" parameter to sha1_object_info_extended()Christian Couder, Dec 7, 2013
  6. 05/10 t6050: show that git cat-file --batch fails with replace objectsChristian Couder, Dec 7, 2013
  7. 06/10 sha1_file: perform object replacement in sha1_object_info_extended()Christian Couder, Dec 7, 2013
  8. 07/10 builtin/replace: teach listing using short, medium or full formatsChristian Couder, Dec 7, 2013
  9. 08/10 t6050: add tests for listing with --formatChristian Couder, Dec 7, 2013
  10. Eric SunshineDec 9, 2013
  11. Christian CouderDec 9, 2013
  12. 09/10 builtin/replace: unset read_replace_refsChristian Couder, Dec 7, 2013
  13. Jakub NarebskiDec 7, 2013
  14. Christian CouderDec 7, 2013
  15. 10/10 Documentation/git-replace: describe --format optionChristian Couder, Dec 7, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.