Re: [PATCH] Document the underlying protocol used by shallow repositories and --depth commands.

From: Alex Neronskiy <zakmagnus@google.com>
Date: Jun 6, 2011, 19:56 UTC
Message-ID: <loom.20110606T213817-376@post.gmane.org>
In-Reply-To: <7vvcwi95yi.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster <at> pobox.com> writes:

Show 9 quoted lines

> > +Once all the 'want's and 'shallow's (and optional 'deepen') are
> > +transferred, clients MUST send a flush-pkt. If the client has all
> > +the references on the server, and as much of their commit history
> > +as it is interested in, client flushes and disconnects.
> 
> Hmmmmm, are you describing "everything-local then flush and all-done" in
> do_fetch_pack() with the second sentence? If so, placing the description
> here is misleading. In that case, I do not think any of the find-common
> exchange starting from the "upload-request" phase happens.

No, this refers to the same event which was already described in that document, which I believe happens from inside find_common. It may just be some confusion on the meaning of "having a reference" on my part, but the idea was to point out that the client could flush at this stage even if it doesn't have every commit.

I tried to amend the existing wording but I suppose it was just misleading, so it's better to write something else entirely.