git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: help with distributed workflow/signoff

From
BPBrock Peabody <brock.peabody@gmail.com>
Date
Jul 14, 2010, 21:46 UTC
Message-ID
<loom.20100714T232116-579@post.gmane.org>
In-Reply-To
<AANLkTilo4TnMQcr7p1dfAeQ4tESHjO4Nbr8274hqxOnD@mail.gmail.com>
Ævar Arnfjörð Bjarmason <avarab <at> gmail.com> writes:
Show 8 quoted lines
> Well, consider that even if you push most patches through, the peer
> review you get from having a setup similar to Git's own might very
> well be worth it. Everyone makes mistakes, having a second set of
> eyeballs to look at your code eliminates a lot of that.
> 
> That may not be acceptable to your corporate culture, but consider
> that most big corporations (e.g. Google) do detailed code review
> before anything gets commited to the master repository.

Yes, that's a good point. We are trying to improve our code review processes, and I think switching to git is going to help with that down the road. I don't want to make the switch to git and a heavier (if better) process at the same time, however, as it would decrease the chance of either being accepted.

Previous: Ævar Arnfjörð BjarmasonNext: A Large Angry SCM
Message 7 of 9 in “help with distributed workflow/signoff”
  1. Brock PeabodyJul 14, 2010
  2. Jonathan NiederJul 14, 2010
  3. Brock PeabodyJul 14, 2010
  4. Avery PennarunJul 14, 2010
  5. Brock PeabodyJul 14, 2010
  6. Ævar Arnfjörð BjarmasonJul 14, 2010
  7. Brock PeabodyJul 14, 2010
  8. A Large Angry SCMJul 14, 2010
  9. Brock PeabodyJul 15, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.