Re: Improving CRLF error message; also, enabling autocrlf and safecrlf by default
- From
- Jason Spiro <jasonspiro4@gmail.com>
- Date
- Feb 16, 2009, 03:29 UTC
- Message-ID
- <loom.20090216T032551-612@post.gmane.org>
- In-Reply-To
- <20090216030446.GC18780@sigill.intra.peff.net>
Jeff King <peff <at> peff.net> writes:
Show 15 quoted lines
>
> On Mon, Feb 16, 2009 at 02:45:43AM +0000, Jason Spiro wrote:
>
> > One of the pre-commit hooks detects trailing whitespace:
> >
> > if (/\s$/) {
> > bad_line("trailing whitespace", $_);
> > }
>
> Not since 03e2b63 (Update sample pre-commit hook to use "diff --check",
> 2008-06-26), when that line was removed.
>
> I'm happy you want to improve git; but please, if you want to report
> problems, check what the status is in a more recent version (or at least
> tell us your version, which can help).Sorry. Will do.
...
> > 2. In addition, could you please enable the core.autocrlf and
core.safecrlf
Show 5 quoted lines
> > options by default in the next version of Git? > > I think that is up to your platform packaging, I think. I think msysgit > is shipping with core.autocrlf on by default these days. But again, I > don't know very much about that area.
Are you saying that only my platform's packager can decide what options are enabled by default, and that you upstream folks have no influence at all? :)