git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] translate bad characters in refnames during git-svn fetch

From
Mike Hommey <mh@glandium.org>
Date
Jul 28, 2007, 07:23 UTC
Message-ID
<loom.20070728T091909-416@post.gmane.org>
In-Reply-To
<20070717122852.GA21372@mayonaise>
Eric Wong <normalperson <at> yhbt.net> writes:
Show 26 quoted lines
> martin f krafft <madduck <at> madduck.net> wrote:
> > also sprach Eric Wong <normalperson <at> yhbt.net> [2007.07.16.0530 +0200]:
> > > The major issue with this is that it doesn't handle odd cases
> > > where a refname is sanitized into something (say "1234~2"
> > > sanitizes to "1234=2"), and then another branch is created named
> > > "1234=2".
> > 
> > Well, we can't please everyone, can we? :)
> > 
> > I like Jan's proposal about using the % escape, even though it
> > doesn't make pretty branch names.
> 
> I like it, too.  How about something like the two functions below?  This
> will break things a bit for people currently using % in refnames,
> however.
> 
> I think this will work rather nicely once I've figured out how the path
> globbing code works[1] and where to sanitize/desanitize the refnames
> properly.
> 
> It would be far easier to take your approach and sanitize them only
> for the command-line, but storing unsanitized git refnames into the
> .git/config is something I want to avoid:
> 
>   Somebody naming directories on the SVN side with the path component
>   ":refs/remotes" in them could screw things up for us.

Why not "simply" allow some form of escaping in refs, such that special characters CAN be used anywhere. Then git-svn would just have to escape these characters.

Something like: git update-ref "refs/remotes/tags/sometag\~1" $sha1

I'm pretty sure that could help fix a lot of other similar issues.
Mike
Previous: Martin F KrafftNext: David Kastrup
Message 9 of 10 in “translate bad characters in refnames during git-svn fetch”
  1. translate bad characters in refnames during git-svn fetchmartin f krafft, Jul 15, 2007
  2. Eric WongJul 16, 2007
  3. Jan HudecJul 16, 2007
  4. martin f krafftJul 16, 2007
  5. Eric WongJul 17, 2007
  6. martin f krafftJul 17, 2007
  7. Robert EwaldJul 26, 2007
  8. Martin F KrafftJul 26, 2007
  9. Mike HommeyJul 28, 2007
  10. David KastrupJul 28, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.