Re: [PATCH v3] clone: error specifically with --local and symlinked objects

From: Glen Choo <chooglen@google.com>
Date: Apr 11, 2023, 18:38 UTC
Message-ID: <kl6lr0sqjmce.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <xmqqmt3e9wab.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 17 quoted lines

> What I locally have, which is an amended version of v2, and this one
> differ like so:
>
> diff --git a/builtin/clone.c b/builtin/clone.c
> index ae2db8535a..b42231758c 100644
> --- a/builtin/clone.c
> +++ b/builtin/clone.c
> @@ -335,7 +335,6 @@ static void copy_or_link_directory(struct strbuf *src, struct strbuf *dest,
>  		if (errno == ENOTDIR) {
>  			int saved_errno = errno;
>  			struct stat st;
> -
>  			if (!lstat(src->buf, &st) && S_ISLNK(st.st_mode))
>  				die(_("'%s' is a symlink, refusing to clone with --local"),
>  				    src->buf);
>
> So I'll keep my copy.

Ah, sharp eye. Sounds good.