Re: [RFC PATCH 1/2] Add C TAP harness

From: Glen Choo <chooglen@google.com>
Date: May 11, 2023, 23:16 UTC
Message-ID: <kl6lpm76zcg7.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <c902a166-98ce-afba-93f2-ea6027557176@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

> It would be possible, but I'd want to see some macros for checking
> invariants that print the source location as well as their
> arguments. I'd be interested to hear what you think of the alternative
> approach in the patch below.

I personally (not representing the Google folks as a whole) find the option of implementing our own C TAP suite quite appealing. As your patch shows, we can get pretty far even with a rudimentary initial version, and I don't see why we couldn't refine it as we go along.

I'm concerned about the overhead of relying on a third party library that implements something moderately complex and isn't widely used, It's much easier to patch and read code that we maintain ourselves, e.g. if we need to fix bugs/add features/understand its behavior. These risks are quite real, especially when it's not clear what kind of support we can rely on from C TAP Harness's side.