ar/submodule-update (wa Re: What's cooking in git.git (Feb 2022, #06; Wed, 23))

From: Glen Choo <chooglen@google.com>
Date: Feb 24, 2022, 17:48 UTC
Message-ID: <kl6lmtig40l4.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <xmqq1qztortk.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 27 quoted lines

> * ar/submodule-update (2022-02-10) 20 commits
>  . fixup! submodule: move core cmd_update() logic to C
>  . fixup! submodule--helper run-update-procedure: learn --remote
>  . fixup! submodule--helper run-update-procedure: remove --suboid
>  . submodule: move core cmd_update() logic to C
>  . submodule--helper: reduce logic in run_update_procedure()
>  . submodule--helper: move functions around
>  . submodule--helper update-clone: learn --init
>  . submodule--helper: remove ensure-core-worktree
>  . submodule--helper run-update-procedure: learn --remote
>  . submodule--helper run-update-procedure: remove --suboid
>  . submodule--helper: reorganize code for sh to C conversion
>  . submodule--helper: remove update-module-mode
>  . submodule tests: test for init and update failure output
>  . submodule--helper: don't use bitfield indirection for parse_options()
>  . builtin/submodule--helper.c: rename option variables to "opt"
>  . builtin/submodule--helper.c: reformat designated initializers
>  . submodule--helper: run update using child process struct
>  . submodule--helper: allow setting superprefix for init_submodule()
>  . submodule--helper: refactor get_submodule_displaypath()
>  . submodule--helper: get remote names from any repository
>
>  Rewrite of "git submodule update" in C.
>
>  Does not seem to play well with other topics in flight, with heavy conflicts.
>  cf. <xmqqv8xj71mt.fsf@gitster.g>
>  source: <20220210092833.55360-1-chooglen@google.com>

I've dug a little deeper, and I think my plan to reroll this as two series [1] makes sense:

1. Small, obvious conversions from sh->C.
2. Finalizing the conversion.

(1) has only trivial conflicts, and is relatively easy to review, so I expect that to go through quickly.

This should also buy some time to finalize those other topics and hopefully make coordination simpler.

[1] https://lore.kernel.org/git/kl6l4k4y59p4.fsf@chooglen-macbookpro.roam.corp.google.com