Re: [PATCH v2 0/3] Fix behavior of worktree config in submodules

From: Glen Choo <chooglen@google.com>
Date: Jun 13, 2023, 22:09 UTC
Message-ID: <kl6lfs6v815k.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <pull.1536.v2.git.1685064781.gitgitgadget@gmail.com>

"Victoria Dye via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 6 quoted lines

>  * Added a commit to move 'struct repository' out of 'git_config_source',
>    rather than creating a dummy 'config_source' just to hold a repository
>    instance.
>  * Changed the config setting in the new tests from 'feature.experimental'
>    to 'index.sparse' to tie these changes to their intended use case.
>  * "super project" -> "superproject"

Thanks! Discounting the discussions on the side thread (which we've decided are mostly out of scope) I think this version is good enough to merge as-is.

In

  https://lore.kernel.org/git/kl6llegnfccw.fsf@chooglen-macbookpro.roam.corp.google.com

I said that this series is better if we squash in a patch to drop the setup code from discover_git_directory(), but on hindsight, I think it also makes perfect sense for me to send that as a standalone patch. Let me know if you plan to squash it in or not so I'll know whether to send it :)