Re: [PATCH v3 0/5] implement branch --recurse-submodules

From: Glen Choo <chooglen@google.com>
Date: Dec 9, 2021, 22:21 UTC
Message-ID: <kl6lee6la07a.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <20211209215912.506354-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 9 quoted lines

> Glen Choo <chooglen@google.com> writes:
>> This version is functionally identical to v2. I've only addressed
>> feedback around code organization, i.e. the the merge conflict with
>> js/branch-track-inherit and making patch 1 easier to review. Thus, some
>> discussions on [1] are still unaddressed.
>
> I do notice that some of my comments on "add --recurse-submodules option
> for branch creation" are still unaddressed so I'll hold off review until
> they are.

Are you referring to your comments on v1 [1]? If so, I believe I had addressed them all in v2 (and v3 is mostly a reorganization of v2).

Let me know what you think is unaddressed :)

[1] https://lore.kernel.org/git/20211124013153.3619998-1-jonathantanmy@google.com