Re: [PATCH v2 0/9] submodule: tests, cleanup to prepare for built-in

From: Glen Choo <chooglen@google.com>
Date: Nov 8, 2022, 19:20 UTC
Message-ID: <kl6ledud45jk.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <221108.86v8npqonn.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 19 quoted lines

> On Tue, Nov 08 2022, Glen Choo wrote:
>
>> [...]
>> Thanks! This addresses all of my comments from v1, and I didn't 
>> spot any other issues during a quick 2nd pass.
>>
>>   Reviewed-by: Glen Choo <chooglen@google.com>
>
> Thanks for the quick review!
>
> One thing I completely forgot in the v2 CL: The 3/9 here is new. Stictly
> speaking we could skip it, but I wanted to be able to mark the new test
> I added as as leak-free, and fixing the only leak it ran into was
> trivial:
> https://lore.kernel.org/git/patch-v2-3.9-a3529d7f9e0-20221108T140501Z-avarab@gmail.com/
>
> So rather than having another "small leak fix for submodules" topic
> depend on this topic, I think it's OK to just bundle that up with this
> one.

Yes, it looked quite trivial. IMO bundling this was a more efficient use of time than sending another series.