git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Bug Report: fetch.recurseSubmodules doesn't affect git pull as otherwise stated in the git config docs

From
Glen Choo <chooglen@google.com>
Date
May 9, 2022, 23:32 UTC
Message-ID
<kl6l5yme8epc.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To
<CAFnZ=JNE_Sa3TsKghBPj1d0cz3kc6o91Ogj-op8o6qK8t9hPgg@mail.gmail.com>
Huang Zou <huang.zou@schrodinger.com> writes:
Show 48 quoted lines
> Thank you for filling out a Git bug report!
> Please answer the following questions to help us understand your issue.
>
> What did you do before the bug happened? (Steps to reproduce your issue)
> 1) Set the following configs:
>  git config submodule.recurse true
>  git config fetch.recurseSubmodules false
> 2) On a repo with submodules, run:
> git pull
>
> What did you expect to happen? (Expected behavior)
> git pull doesn't recursively fetch submodules
>
> What happened instead? (Actual behavior)
> Submodules are fetched recursively
>
> What's different between what you expected and what actually happened?
> Submodules are fetched recursively
>
> Anything else you want to add:
> git fetch works as intended. The documentation for fetch.recurseSubmodules
> states that "This option controls whether git fetch (and the underlying
> fetch in git pull)" so I would naturally expect git pull to behave the same
> as git fetch
>
>
>
> [System Info]
> git version:
> git version 2.36.0
> cpu: x86_64
> no commit associated with this build
> sizeof-long: 8
> sizeof-size_t: 8
> shell-path: /bin/sh
> feature: fsmonitor--daemon
> uname: Darwin 19.6.0 Darwin Kernel Version 19.6.0: Tue Aug 24 20:28:00 PDT
> 2021; root:xnu-6153.141.40~1/RELEASE_X86_64 x86_64
> compiler info: clang: 12.0.0 (clang-1200.0.32.29)
> libc info: no libc information available
> $SHELL (typically, interactive shell): /usr/local/bin/bash
>
>
> [Enabled Hooks]
> pre-commit
>
> Thanks,
> Huang

I've sent a fix at [1] :) I intended for the patch to be sent in reply to this thread, but I clearly don't know how to use GitGitGadget correctly. Whoops

[1] https://lore.kernel.org/git/pull.1262.git.git.1652138854255.gitgitgadget@gmail.com/
Previous: Huang ZouNext: Philippe Blain
Message 6 of 7 in “Bug Report: fetch.recurseSubmodules doesn't affect git pull as otherwise stated in the git config docs”
  1. Huang ZouMay 2, 2022
  2. Philippe BlainMay 5, 2022
  3. Glen ChooMay 6, 2022
  4. Philippe BlainMay 6, 2022
  5. Huang ZouMay 9, 2022
  6. Glen ChooMay 9, 2022
  7. Philippe BlainMay 10, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.