Re: [PATCH v4 0/7] No more adding submodule ODB as alternate

From: Glen Choo <chooglen@google.com>
Date: Oct 12, 2021, 22:10 UTC
Message-ID: <kl6l4k9l3ned.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <cover.1633727270.git.jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

> Thanks everyone for your reviews. Here's an updated patch set, including
> Carlo's fixup squashed.

This series LGTM. My comments on v3 center around the remaining references to the_repository, but as you have noted, we aren't at a stage where we can remove the_repository. Rather, we are making the_repository explicit in anticipation of removing the_repository from the entire ref writing system.

I have some reservations about adding the backpointer from ref_store to repository. I don't think this is the best long-term API, but it is a reasonable step towards removing the_repository from the ref writing system, and as Josh mentioned:

  This seems reasonable as we don't keep a lot of these structs around,
  so the additional memory usage isn't much of a concern.

Reviewed-by: Glen Choo <chooglen@google.com>