Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability
- From
Joachim Schmitz <jojo@schmitz-digital.de>
- Date
- Oct 9, 2012, 07:15 UTC
- Message-ID
- <k50iuv$j0b$1@ger.gmane.org>
- In-Reply-To
- <7vd30snbtk.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
Show 22 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > >> Ben Walton <bdwalton@gmail.com> writes: >> >>> Avoid a GNU-ism in the cp options used by t5400-send-pack. Change >>> -a >>> to -pR. >>> >>> Signed-off-by: Ben Walton <bdwalton@gmail.com> >>> --- >> >> Thanks, but is "-p" essential for this test to pass, or can we get >> away with just "-R"? > > Besides, when you spot a potential problem, please ask "git grep" > to catch them all. > > $ git grep "cp -a" t/ > t/t5400-send-pack.sh: cp -a parent child && > t/t5550-http-fetch.sh: cp -a > .git"$HTTPD_DOCUMENT_ROOT_PATH/repo.git" && > t/t5800-remote-helpers.sh: cp -a server server2 &&
There's 2 more places in Documentation/git-tutorial.txt. There it looks like we'd want to use 'cp -pR' instead
Bye, Jojo