git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/4] poll() exits too early with EFAULT if 1st arg is NULL

From
Joachim Schmitz <jojo@schmitz-digital.de>
Date
Sep 11, 2012, 11:28 UTC
Message-ID
<k2n79l$s9e$1@ger.gmane.org>
In-Reply-To
<003a01cd8cf7$af821100$0e863300$@schmitz-digital.de>
Joachim Schmitz wrote:
Show 24 quoted lines
> If poll() is used as a milli-second sleep, like in help.c, by passing
> a NULL in the 1st and a 0 in the 2nd arg, it exits with EFAULT.
>
> As per Paolo Bonzini, the original author, this is a bug and to be
> fixed like in this commit, which is not to exit if the 2nd arg is 0.
>
> Signed-off-by: Joachim Schmitz <jojo@schmitz-digital.de>
> ---
> compat/win32/poll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/compat/win32/poll.c b/compat/win32/poll.c
> index 403eaa7..9e7a25c 100644
> --- a/compat/win32/poll.c
> +++ b/compat/win32/poll.c
> @@ -349,7 +349,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
>
>   /* EFAULT is not necessary to implement, but let's do it in the
>      simplest case. */
> -  if (!pfd)
> +  if (!pfd && nfd)
>     {
>       errno = EFAULT;
>       return -1;

Actually this one is not needed for win32 (nor does win32 suffer from a similar bug), so should probably better get added after patch 2/2 (or as part of it), the move to compat/poll/.

Bye, Jojo
Previous: Joachim SchmitzNext: Joachim Schmitz
Message 2 of 3 in “RE: [PATCH v3 1/4] poll() exits too early with EFAULT if 1st arg is NULL”
  1. Joachim SchmitzSep 7, 2012
  2. Joachim SchmitzSep 11, 2012
  3. Joachim SchmitzSep 13, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.