git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] t9001: use older Getopt::Long boolean prefix '--no' rather than '--no-'

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Dec 22, 2010, 23:58 UTC
Message-ID
<jpN7nm-rtl4sNXi5qt9pXHOvlLOZP9xRq2h9eZev444l6GTi02jDn5C-Llxwsz3_tVhVKGvU5Vryto5cM6uchw@cipher.nrlssc.navy.mil>
In-Reply-To
<jpN7nm-rtl4sNXi5qt9pXMafcDOI0AxF95o77x_r5JQwZeaH94BApUuIwonUaYfzmYTgqeFNpSm6S7VFnIZVag@cipher.nrlssc.navy.mil>
From: Brandon Casey <drafnel@gmail.com>

The '--no-chain-reply-to' option is a Getopt::Long boolean option. The '--no-' prefix (as in --no-chain-reply-to) for boolean options is not supported in Getopt::Long version 2.32 which was released with Perl 5.8.0. This version only supports '--no' as in '--nochain-reply-to'. More recent versions of Getopt::Long, such as version 2.34, support either prefix. So use the older form in the tests.

See also:

907a0b1e04ea31cb368e9422df93d8ebb0187914 84eeb687de7a6c7c42af3fb51b176e0f412a979e 3fee1fe87144360a1913eab86af9ad136c810076

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---
 t/t9001-send-email.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 5e48318..1dc4a92 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -319,7 +319,7 @@ test_expect_success $PREREQ 'In-Reply-To without --chain-reply-to' '
 	git send-email \
 		--from="Example <nobody@example.com>" \
 		--to=nobody@example.com \
-		--no-chain-reply-to \
+		--nochain-reply-to \
 		--in-reply-to="$(cat expect)" \
 		--smtp-server="$(pwd)/fake.sendmail" \
 		$patches $patches $patches \
-- 
1.7.3.1
Previous: Brandon CaseyNext: Junio C Hamano
Message 3 of 7 in “Makefile: add NO_FNMATCH_CASEFOLD to IRIX sections”
  1. 1/3 Makefile: add NO_FNMATCH_CASEFOLD to IRIX sectionsBrandon Casey, Dec 22, 2010
  2. 2/3 test-lib.sh/test_decode_color(): use octal not hex in awk scriptBrandon Casey, Dec 22, 2010
  3. 3/3 t9001: use older Getopt::Long boolean prefix '--no' rather than '--no-'Brandon Casey, Dec 22, 2010
  4. Junio C HamanoDec 23, 2010
  5. Brandon CaseyDec 23, 2010
  6. Junio C HamanoDec 23, 2010
  7. Brandon CaseyDec 23, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.