Re: [PATCH 1/1] doc/gitcli: minor fixes
- From
Dirk Gouders <dirk@gouders.net>
- Date
- Nov 14, 2026, 22:09 UTC
- Message-ID
- <ghik1z6p6c.fsf@gouders.net>
- In-Reply-To
- <xmqqik1znkn8.fsf@gitster.g>
On Sat, Nov 14 2026, Junio C Hamano wrote:
Show 20 quoted lines
> Dirk Gouders <dirk@gouders.net> writes: > >> -This manual describes the convention used throughout Git CLI. >> +This manual describes the conventions used throughout Git CLI. > > OK. > >> @@ -28,7 +28,7 @@ arguments. Here are the rules: >> `v1.0` and `v2.0` are revisions and `arch/x86` and `include/asm-x86` >> are paths. >> >> - * When an argument can be misunderstood as either a revision or a path, >> + * When arguments can be misunderstood as either a revision or a path, >> they can be disambiguated by placing `--` between them. > > I would rather have left the subject as-is, and then rewrote the > conclusion part to "it can be disambiguated by placing `--` before > or arter it". Once you start talking about multiple arguments, you > would have to also reorder them so that all revs come first, then > '--', and then all paths.
Thank you for the quick review.
Yes, there were two possible fixes for this second detail. I will send a v2 according to your suggestion.
Regards,
Dirk
Show 12 quoted lines
>> @@ -76,8 +76,8 @@ you will. >> Here are the rules regarding the "flags" that you should follow when you are >> scripting Git: >> >> - * Splitting short options to separate words (prefer `git foo -a -b` >> - to `git foo -ab`, the latter may not even work). >> + * Split short options to separate words: prefer `git foo -a -b` >> + to `git foo -ab` (the latter may not even work). > > OK. > > Thanks.