git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/4] utf8: fix comment for utf8_strnwidth()

From
Dirk Gouders <dirk@gouders.net>
Date
Nov 19, 2026, 05:58 UTC
Message-ID
<gh1p8hbbvv.fsf@gouders.net>
In-Reply-To
<CAHWeT-Zzvjx5knLdCdxUmn8zmkAk2qrzzvXkbSjhCibWy7hAeQ@mail.gmail.com>
On Wed, Nov 18 2026, Andy Koppe wrote:
Show 17 quoted lines
> Dirk Gouders wrote:
>>
>> The comment for utf8_strnwidth() states it returns strlen() for cases
>> when the given string doesn't look like valid utf8, but it returns its
>> argument len in such cases.
>>
>> Fix the comment accordingly.
> …
>>  /*
>>   * Returns the total number of columns required by a null-terminated
>> - * string, assuming that the string is utf8.  Returns strlen() instead
>> + * string, assuming that the string is utf8.  Returns len instead
>>   * if the string does not look like a valid utf8 string.
>>   */
>>  int utf8_strnwidth(const char *string, size_t len, int skip_ansi)
>
> "null-terminated" is wrong too.
Yes, I will fix that, too.  Thank you.
Dirk
Previous: Andy KoppeNext: Dirk Gouders
Message 22 of 26 in “utf8: two minor fixes”
  1. 0/2 utf8: two minor fixesDirk Gouders, Nov 16, 2026
  2. 1/2 utf8: respect bounds in utf8_strnwidth()Dirk Gouders, Nov 16, 2026
  3. Junio C HamanoNov 17, 2026
  4. Dirk GoudersNov 17, 2026
  5. Junio C HamanoNov 17, 2026
  6. Dirk GoudersNov 17, 2026
  7. Junio C HamanoNov 17, 2026
  8. 2/2 utf8: fix comment for utf8_strnwidth()Dirk Gouders, Nov 16, 2026
  9. 0/4 utf8: bounds-related fixes and a doc fixDirk Gouders, Nov 18, 2026
  10. 1/4 utf8: add display_mode_esc_sequence_len_counted()Dirk Gouders, Nov 18, 2026
  11. Andy KoppeNov 19, 2026
  12. Dirk GoudersNov 19, 2026
  13. Andy KoppeNov 19, 2026
  14. Andy KoppeNov 19, 2026
  15. Dirk GoudersNov 19, 2026
  16. Dirk GoudersNov 19, 2026
  17. Dirk GoudersNov 19, 2026
  18. Junio C HamanoNov 19, 2026
  19. Dirk GoudersNov 19, 2026
  20. 2/4 utf8: fix comment for utf8_strnwidth()Dirk Gouders, Nov 18, 2026
  21. Andy KoppeNov 18, 2026
  22. Dirk GoudersNov 19, 2026
  23. 3/4 utf8: respect string boundaries after skipping ANSI escape sequencesDirk Gouders, Nov 18, 2026
  24. Junio C HamanoNov 18, 2026
  25. 4/4 utf8: respect boundaries in utf8_strnwidth()Dirk Gouders, Nov 18, 2026
  26. Junio C HamanoNov 18, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.