Re: [PATCH v3] ls-remote: fall-back to default remotes when no remote specified

From: Tay Ray Chuan <rctay89@gmail.com>
Date: Apr 9, 2010, 09:15 UTC
Message-ID: <g2ube6fef0d1004090215uefd96052w64de7233c26002ae@mail.gmail.com>
In-Reply-To: <A612847CFE53224C91B23E3A5B48BAC7448206860D@xmail3.se.axis.com>

Hi,

On Fri, Apr 9, 2010 at 4:49 PM, Peter Kjellerstedt <peter.kjellerstedt@axis.com> wrote:

Show 14 quoted lines

>> From: git-owner@vger.kernel.org [mailto:git-owner@vger.kernel.org] On
>> Behalf Of Tay Ray Chuan
>>  static const char ls_remote_usage[] =
>> -"git ls-remote [--heads] [--tags]  [-u <exec> | --upload-pack <exec>] <repository> <refs>...";
>> +       "git ls-remote [--heads] [--tags]  [-u <exec> | --upload-pack <exec>]\n"
>> +"                     [<repository> [<refs>...]]";
>
> That should be:
>
> static const char ls_remote_usage[] =
>        "git ls-remote [--heads] [--tags]  [-u <exec> | --upload-pack <exec>]\n"
>        "              [<repository> [<refs>...]]";
>
> or the second line of the usage will not be indented as intended.

Nope, you are not right - you didn't take into account the "usage: " string that is prepended. (The non-printed whitespace in front of "git ls-remote..." is equivalent to that string.)

-- 
Cheers,
Ray Chuan