Re: [BUG] Git add <device file> silently fails

From: Alex Riesen <raa.lkml@gmail.com>
Date: Apr 17, 2010, 15:27 UTC
Message-ID: <g2h81b0412b1004170827y883c0cc8ofc72712c20e95dc8@mail.gmail.com>
In-Reply-To: <201004171700.22851.agruen@suse.de>

On Sat, Apr 17, 2010 at 17:00, Andreas Gruenbacher <agruen@suse.de> wrote:

Show 6 quoted lines

> On Saturday 17 April 2010 16:44:05 Alex Riesen wrote:
>> I think something like this should make the accident more
>> noticable:
>
> Doesn't actually tell what the problem might be, though.
>

Oh, sorry. Somehow I thought, you did found what the problem is (Git is not an archiving tool and does not store irregular files), and just wanted to point at "git add" failing silently adding such a name.

In this particular case, the name you given to Git, is a device entry point, which is filtered. Far too early, in my opinion, so no sensible diagnostics can be produced. That's why I suggested an exit with generic error message. I hope it is enough to at least point the user to where a problem (like a fifo, device or socket give in the command line) might be.