git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: Fix chop_str not to cut in middle of utf8 multibyte chars.

From
Anders Waldenborg <anders@0x63.nu>
Date
May 20, 2008, 20:55 UTC
Message-ID
<g0vdse$rj6$1@ger.gmane.org>

Without this fix at least author name in short log may cut in middle of a multibyte char. When the result comes to esc_html to_utf8 is called again, which doesn't find valid utf8 and decodes using $fallback_encoding making it even worse.

Signed-off-by: Anders Waldenborg <anders@0x63.nu>
---
  gitweb/gitweb.perl |    4 ++++
  1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 2facf2d..8308e22 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -866,6 +866,10 @@ sub chop_str {
         my $add_len = shift || 10;
         my $where = shift || 'right'; # 'left' | 'center' | 'right'

+       # Make sure perl knows it is utf8 encoded so we don't
+       # cut in the middle of a utf8 multibyte char.
+       $str = to_utf8($str);
+
         # allow only $len chars, but don't cut a word if it would fit in $add_len
         # if it doesn't fit, cut it if it's still longer than the dots we would add
         # remove chopped character entities entirely
Next: Jakub Narebski
Message 1 of 6 in “gitweb: Fix chop_str not to cut in middle of utf8 multibyte chars.”
  1. gitweb: Fix chop_str not to cut in middle of utf8 multibyte chars.Anders Waldenborg, May 20, 2008
  2. Jakub NarebskiMay 20, 2008
  3. Junio C HamanoMay 21, 2008
  4. Anders WaldenborgMay 21, 2008
  5. Jakub NarebskiMay 24, 2008
  6. gitweb: Convert string to internal form before chopping in chop_strAnders Waldenborg, May 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.