Re: [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences

From: Johannes Sixt <j6t@kdbg.org>
Date: Feb 27, 2026, 07:37 UTC
Message-ID: <ffd58cd5-811b-4ebf-8572-cca681ec9bf7@kdbg.org>
In-Reply-To: <pull.2217.git.git.1772109195114.gitgitgadget@gmail.com>

Am 26.02.26 um 13:33 schrieb Gary Wang via GitGitGadget:

Show 11 quoted lines

> From: Wang Zichong <wangzichong@deepin.org>
> 
> As a dark-theme user, I use the Preferences dialog to set colors
> for gitk, the only color I cannot change via that dialog is the
> link foreground color, which will lead me to use the default link
> color on a dark background that make it not really readable.
> 
> This patch makes the link foreground color also configurable in the
> Gitk Preferences dialog's Color tab, so user won't need to dig into
> the code/manual to know if the link color is configurable and can
> simply set the color there.

Makes sense.

Our usual style is to not say "This patch does X to...", but to write in imperative mood "Do X to...".

Show 5 quoted lines

> 
> CC: Mark Levedahl <mlevedahl@gmail.com>, Paul Mackerras <paulus@samba.org>
> Signed-off-by: Wang Zichong <wangzichong@deepin.org>
> ---
>     gitk: support config the color of linkfgcolor via Gitk Preferences

In the subject line, perhaps:

   gitk: support link color in the Preferences dialog

> +    label $page.linkfg -padx 40 -relief sunk -background $linkfgcolor
> +    ttk::button $page.linkfgbut -text [mc "Link color"] \
> +        -command [list choosecolor linkfgcolor {} $page [mc "link color"]]

This text "link color" is used in the title of the color selection dialog. It then reads awkwardly "Gitk: choose color for link color". Let's just use the text "links" for this purpose, and then also just "Links" as the label on the button.

Show 5 quoted lines

> @@ -11891,6 +11896,7 @@ proc prefspage_set_colorswatches {page} {
>      $page.hunksep configure -background [lindex $diffcolors 2]
>      $page.markbgsep configure -background $markbgcolor
>      $page.selbgsep configure -background $selectbgcolor
> +    $page.linkfg configure -background $linkfgcolor

The variable's value is already serialized in the configuration and needs no additional treatment. Good.

-- Hannes