Re: [PATCH 3/4] replace-objects: evaluate replacement refs without using the object store

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Sep 13, 2017, 08:03 UTC
Message-ID: <fe956802-41ab-783f-62b3-f7c4b8292e8c@alum.mit.edu>
In-Reply-To: <20170912173140.GD144745@aiede.mtv.corp.google.com>

On 09/12/2017 07:31 PM, Jonathan Nieder wrote:

Show 16 quoted lines

> From: Stefan Beller <sbeller@google.com>
> 
> Pass DO_FOR_EACH_INCLUDE_BROKEN when iterating over replacement refs
> so that the iteration does not require opening the named objects from
> the object store. This avoids a dependency cycle between object access
> and replace ref iteration.
> 
> Moreover the ref subsystem has not been migrated yet to access the
> object store via passed in repository objects.  As a result, without
> this patch, iterating over replace refs in a repository other than
> the_repository it produces errors:
> 
>    error: refs/replace/3afabef75c627b894cccc3bcae86837abc7c32fe does not point to a valid object!
> 
> Noticed while adapting the object store (and in particular its
> evaluation of replace refs) to handle arbitrary repositories.

Have you checked that consumers of this API can handle broken references? Aside from missing values, broken references can have illegal names (though hopefully not unsafe in the sense of causing filesystem traversal outside of `$GITDIR`).

Michael