Re: [PATCH 1/1] reset: support the --stdin option
- From
- Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
- Date
- Sep 5, 2019, 10:58 UTC
- Message-ID
- <fd300972-4fe7-54e4-3701-061ab4769c10@syntevo.com>
- In-Reply-To
- <017945a55a64ebe1913d64919b699adb3f9d5d96.1567633109.git.gitgitgadget@gmail.com>
Johannes, thanks for working on this problem!
In the previous discussion, there was a suggestion to change '--stdin' to '--paths-file', where '--paths-file -' would mean stdin: https://public-inbox.org/git/066cfd61-9700-e154-042f-fc9cffbd6346@web.de/
I believe that was a good suggestion for a few reasons:
1) Supporting files in addition to stdin sounds reasonable for its cost.
2) '--paths-file' will support files and stdin with the same "interface",
avoiding the possible need for another interface later.
3) '--paths-file' sounds more self-documented then '--stdin'.Later, we intend to provide patches to extend the same feature to multiple other commands, at least {add, checkout, commit, rm, stash}, and I'm merely trying to avoid possible design issues for this larger-scale change.
If you don't mind the suggestion but not willing to spend time implementing it, we'd like to step in and contribute the remaining work.