git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/4] checkout: support renormalization with checkout -m <paths>

From
Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Date
Aug 2, 2020, 06:33 UTC
Message-ID
<fcc7ea3add7fc0d3031a944b3da9b882f36981da.1596349986.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.825.git.git.1596349986.gitgitgadget@gmail.com>
From: Elijah Newren <newren@gmail.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
---
 builtin/checkout.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/builtin/checkout.c b/builtin/checkout.c
index 18c49034c4..2837195491 100644
--- a/builtin/checkout.c
+++ b/builtin/checkout.c
@@ -239,6 +239,8 @@ static int checkout_merged(int pos, const struct checkout *state, int *nr_checko
 	mmbuffer_t result_buf;
 	struct object_id threeway[3];
 	unsigned mode = 0;
+	struct ll_merge_options ll_opts;
+	int renormalize = 0;
 
 	memset(threeway, 0, sizeof(threeway));
 	while (pos < active_nr) {
@@ -259,13 +261,12 @@ static int checkout_merged(int pos, const struct checkout *state, int *nr_checko
 	read_mmblob(&ours, &threeway[1]);
 	read_mmblob(&theirs, &threeway[2]);
 
-	/*
-	 * NEEDSWORK: re-create conflicts from merges with
-	 * merge.renormalize set, too
-	 */
+	memset(&ll_opts, 0, sizeof(ll_opts));
+	git_config_get_bool("merge.renormalize", &renormalize);
+	ll_opts.renormalize = renormalize;
 	status = ll_merge(&result_buf, path, &ancestor, "base",
 			  &ours, "ours", &theirs, "theirs",
-			  state->istate, NULL);
+			  state->istate, &ll_opts);
 	free(ancestor.ptr);
 	free(ours.ptr);
 	free(theirs.ptr);
-- 
gitgitgadget
Previous: Elijah NewrenNext: Elijah Newren via GitGitGadget
Message 9 of 18 in “Attr fixes”
  1. 0/4 Attr fixesElijah Newren via GitGitGadget, Aug 2, 2020
  2. 1/4 t6038: make tests fail for the right reasonElijah Newren via GitGitGadget, Aug 2, 2020
  3. Junio C HamanoAug 2, 2020
  4. Eric SunshineAug 2, 2020
  5. Elijah NewrenAug 3, 2020
  6. 3/4 merge: make merge.renormalize work for all uses of merge machineryElijah Newren via GitGitGadget, Aug 2, 2020
  7. Junio C HamanoAug 2, 2020
  8. Elijah NewrenAug 3, 2020
  9. 4/4 checkout: support renormalization with checkout -m <paths>Elijah Newren via GitGitGadget, Aug 2, 2020
  10. 2/4 t6038: fix test with obviously incorrect expectationsElijah Newren via GitGitGadget, Aug 2, 2020
  11. Junio C HamanoAug 2, 2020
  12. Elijah NewrenAug 3, 2020
  13. Junio C HamanoAug 3, 2020
  14. 0/4 Attr fixesElijah Newren via GitGitGadget, Aug 3, 2020
  15. 1/4 t6038: make tests fail for the right reasonElijah Newren via GitGitGadget, Aug 3, 2020
  16. 4/4 checkout: support renormalization with checkout -m <paths>Elijah Newren via GitGitGadget, Aug 3, 2020
  17. 2/4 t6038: remove problematic testElijah Newren via GitGitGadget, Aug 3, 2020
  18. 3/4 merge: make merge.renormalize work for all uses of merge machineryElijah Newren via GitGitGadget, Aug 3, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.