Re: [PATCH] Allow passing of configuration parameters in the command line

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Mar 20, 2010, 09:09 UTC
Message-ID: <fcaeb9bf1003200209r6051f906kf2a0a1e96752845e@mail.gmail.com>
In-Reply-To: <7vmxy4kss9.fsf@alter.siamese.dyndns.org>

On 3/20/10, Junio C Hamano <gitster@pobox.com> wrote:

Show 16 quoted lines

> Alex Riesen <raa.lkml@gmail.com> writes:
>
>  > The values passed this way will override whatever is defined
>  > in the config files.
>  >
>  > Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
>  > ---
>  >
>  > Someone wanted to have this once. I accidentally remembered
>  > that when I wanted to temporarily set some config parameter
>  > (format.suffix?). From looking at code it seemed simple enough,
>  > so I did it.
>
>
> How does this interact with core.worktree and the setup sequence in
>  general?

To me it looks like another config file to the config stack. No thing can go worse (except that if you have core.worktree in $GIT_DIR/config, now also specify -c core.worktree=foo, then core.worktree code would be called twice).

However, specifying "-c foo=relativepath" may surprise users. Current working directory may have been moved when that config is used.

-- 
Duy